When retrying to resolveOrCreateNetwork, retry with a valid network name #12422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
compose sometimes fail to start a basic stack with a network error
Network tmp_default was found but has incorrect label com.docker.compose.network set to "default" (expected "")
The same compose file might succeed or fail randomly. Given the error message, when it fails the network name param is empty here, that is very likely due to the retry that passes an empty string instead of the actual name, passed in the first invocation (and the error message indicates that resolution would succeed if the name
default
was passed as expected).This PR passes the same name param when retrying as in the initial invocation (I might miss some context, if there was a specific reason to pass empty on the retry?)
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did