Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When retrying to resolveOrCreateNetwork, retry with a valid network name #12422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Dec 24, 2024

What I did

compose sometimes fail to start a basic stack with a network error
Network tmp_default was found but has incorrect label com.docker.compose.network set to "default" (expected "")

The same compose file might succeed or fail randomly. Given the error message, when it fails the network name param is empty here, that is very likely due to the retry that passes an empty string instead of the actual name, passed in the first invocation (and the error message indicates that resolution would succeed if the name default was passed as expected).

This PR passes the same name param when retrying as in the initial invocation (I might miss some context, if there was a specific reason to pass empty on the retry?)

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

octupus

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant