-
Notifications
You must be signed in to change notification settings - Fork 2k
FR: Get internal IP of cloud hosted machine #1342
Comments
I have heard that |
It will. For a command though, perhaps machine ip --internal would be cool. |
|
@nathanleclaire adding a private ip command isn't too difficult, but it would require an update to a driver spec, wouldn't it? Wanted to check your stance on this, as it will cut across every driver implementation as a result. |
@aperepel IMO it probably should. Something like |
Yes, we would have to update the drivers to have such a method. |
I could take a look, but before I do, any tips on picking up an internal IP? E.g. I had cases when 5 different ones were returned. |
…actual implementation for GCE, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
…actual implementation for GCE, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
…actual implementation for GCE, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
…actual implementation for GCE, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
…actual implementation for GCE, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
Hey guys, I took the first cut and implemented the GCE driver support (ways to get at private ip will differ greatly for each provider). All other drivers are simply throwing an error for the GetPrivateIP() #1355 |
…Implemented support for VirtualBox (and some refactoring) Signed-off-by: Andrew Grande <aperepel@gmail.com>
Figured out the VirtualBox part too, added to the same PR. |
…implementation for GCE and VirtualBox, placeholders for the rest currently) Signed-off-by: Andrew Grande <aperepel@gmail.com>
Thanks for your PR @aperepel. I hope this will get some docker love eventually! |
Hi! This would be an awesome feature for my use case. Are you still working on this @aperepel? I can PR this. |
Hi guys, any news on this? I'm in great need of this featuring and looking to contribute this to the drivers. Wanted to know how it's the best way to handle this change on the driver interface. Thanks. |
It would be great if I could get the internal/private IP address of my machine for doing some cluster management work. currently
docker-machine ip mymachine
will give me the external IP address.it would be awesome if it were possible to have something like
docker-machine private-ip mymachine
. This way I can build configurations using the docker-machine CLI.i noticed in the diagnostics it's grabbing this so perhaps it wouldn't be hard to add. I need to work on my go skills so I can contribute
The text was updated successfully, but these errors were encountered: