New Driver: CenturyLink Cloud #467
Conversation
dpetersen
force-pushed
the
centurylinkcloud
branch
from
583f585 to
d15e909
Compare
Running 'godep save' caused total havoc with the Godeps file and removed a lot of dependencies that had nothing to do with the work I'm doing. I'm unsure whether the version of godep I'm using is rastically different than the one used to update this project last time. Signed-off-by: Don Petersen <don@donpetersen.net>
dpetersen
force-pushed
the
centurylinkcloud
branch
from
d15e909 to
6224519
Compare
Signed-off-by: Don Petersen <don@donpetersen.net>
It references a directory that no longer exists. Signed-off-by: Don Petersen <don@donpetersen.net>
dpetersen
force-pushed
the
centurylinkcloud
branch
from
6224519 to
9d1e813
Compare
|
Hey @ehazlett, did you see the old email chain that I resurrected on 7/2 around this driver PR? |
I could have sworn I checked that syntax on shorter strings before I used it...
On the Debian version that Chaitanya was testing, it didn't exist and was breaking machine setup.
You have to run machine from a machine on the same private network, but it works.
|
Hi , thanks for your efforts and persistence in submitting this driver. We are extremely excited that there is so much interest in Docker Machine and we really appreciate your interest. However, at this time it is proving to be extremely difficult for us to keep up with reviewing and testing each of these drivers for inclusion in the Machine core. We really want to switch to a more pluggable model, as well as polish up a few things about the driver model which need to be changed to ensure a smooth and sustainable future. Therefore, we will be moving to a plugin model for 0.5 and would love to have you involved in the design and development process. We are closing the outstanding driver PRs at this time, but please keep the code. We will stick closely to the current driver interface and you should be able to re-use a lot (if not all) of the existing driver along with the new plugin model. We will be moving all of the drivers which are merged directly into Machine today to the plugin model when it is available, so there will be no special treatment of those, and there will be documentation outlining the process of developing and using a Docker Machine driver plugin. With all of that being said, we want to apologize for the lack of feedback on your pull request. As contributors ourselves, we understand that being left in limbo is no fun. We would have liked to address this sooner, and in the future we will be more responsive around these kinds of issues. Once again, we thank you for the contribution and the tremendous support. Keep hacking strong! If you want to contribute to the design of the plugin model, we'd love to get your input on this issue where we will be planning it: |
Speed up ssh access by turning off DNS checking
This adds the code and documentation for a CenturyLink Cloud driver. It's failing consistently on two integration tests, but it's a pair of tests that are also failing for me using the DigitalOcean driver (they're both around what the CLI displays once a server is stopped). Are there some known failures in master right now?
I have the latest version of
godepinstalled, and doing agodep saveto add my single new dependency is causing an enormous number of unrelated dependencies to be removed from the manifest (mostly docker libraries!). Is there a special syntax to use for adding dependencies? I manually tweaked the manifest in my vendoring commit.I couldn't help but notice that none of the drivers are implementing anything in
Authorize/DeauthorizePort. I know my API is capable of adding and removing ports from a public IP address, but I just did a dummy implementation of that since it doesn't appear to be used anywhere in the code.Last but not least, while I was in there I noticed an old integration test script that doesn't seem to be referenced anymore. I tacked that onto this PR, but I can knock that commit off if I'm missing something.