Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix issue when scanning a local image with the snyk containerized pro… #152

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

glours
Copy link
Collaborator

@glours glours commented Apr 22, 2021

…vider

Signed-off-by: Guillaume Lours guillaume.lours@docker.com

fixes #151

- What I did
Use the snyk/snyk:docker image instead of the snyk/snyk:alpine one

- How I did it
Change the SHA of the image in the vars.mk file
Add a e2e test which build a local image and try to scan this image with the containerized Snyk Provider

- How to verify it
e2e test should pass
On linux :

$ docker build -f ./e2e/testdata/Dockerfile -t local:build .

# when the image have been built 
$ docker scan local:build
...
Organization:      docker-desktop-test
Package manager:   apk
Project name:      docker-image|local
Docker image:      local:build
Platform:          linux/amd64
Licenses:          enabled

Tested 14 dependencies for known issues, found 15 issues.

- A picture of a cute animal (not mandatory)

image

…vider

Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours added the bug 🐞 App is not working correctly. label Apr 22, 2021
@glours glours self-assigned this Apr 22, 2021
Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/scan_test.go Outdated Show resolved Hide resolved
Co-authored-by: Chris Crone <christopher.crone@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours force-pushed the fix-local-image-scan branch from c82730d to 067be3a Compare April 23, 2021 07:51
@glours glours merged commit de4c2c6 into main Apr 23, 2021
@glours glours deleted the fix-local-image-scan branch April 23, 2021 08:27
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug 🐞 App is not working correctly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux docker scan not working for locally built/cache image
3 participants