This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Build mac arm64 binary #189
Merged
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
|
Unfortunately that's not enough to be able to produce a darwin arm64 binary |
|
Thanks @glours and I wondered why we have a mixture of setup Go 1.15 and 1.17. I'll update my PR. |
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Scherer stefan.scherer@docker.com
- What I did
Build a Mac arm64 binary for Docker Desktop to make
docker scanwork without Rosetta 2.- How I did it
As GH actions runners don't have arm64 nodes, we have to cross build the binary.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory)