Skip to content

[build] convert external dependencies (missing dependencies) into Rollup errors instead of warnings. #1210

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
trusktr opened this issue Jun 10, 2020 · 1 comment · Fixed by #1232
Closed

[build] convert external dependencies (missing dependencies) into Rollup errors instead of warnings. #1210

trusktr opened this issue Jun 10, 2020 · 1 comment · Fixed by #1232
Assignees
@trusktr
Labels
build This is related to build process ready to implement

Comments

@trusktr
Copy link
Member

trusktr commented Jun 10, 2020

Rollup by default treats missing dependencies as "external" and will only output a warning to the console instead of an error (working as intended).

We can make it throw an error for our use case.

See: rollup/rollup#1906 (comment)
@trusktr trusktr added ready to implement build This is related to build process labels Jun 10, 2020
@trusktr trusktr self-assigned this Jun 10, 2020
@mohammedsahl
Copy link
Contributor

I'd like to work on this. How would you suggest going about with testing? Can you tell me of a way to reproduce the missing dependencies warning. @trusktr

ianjennings added a commit to ianjennings/docsify that referenced this issue Jun 17, 2020
@ianjennings
Estimated solution for docsify/docsify#1210
3ff6737 
docsifyjs#1210
@mohammedsahl mohammedsahl mentioned this issue Jun 19, 2020
Merged
19 tasks
@jhildenbiddle jhildenbiddle linked a pull request Jun 22, 2020 that will close this issue
fix: #1210 - Add error handling for missing dependencies #1232
Merged
19 tasks
anikethsaha pushed a commit that referenced this issue Jun 23, 2020
@mohammedsahl
fix: Add error handling for missing dependencies (fixes #1210) (#1232)
3673001 
* Add error handling for missing dependencies

* Informative error message

* Add error handling for missing dependencies

* Informative error message

* Add dependecy import location, error message changes
trusktr added a commit that referenced this issue Jul 4, 2020
@trusktr
Merge branch 'develop' into docsify-class
fc71b56 
* develop:
  docs: removed codefund docs and plugin (#1262)
  docs: remove bundle size from the home page and documentation (#1257)
  fix: search can not search the table header (#1256)
  fix: after setting the background image, the button is obscured (#1234)
  Fix: fixed onlycover flag in mobile (#1243)
  fix: Updated docs with instructions for installing specific version (fixes #780) (#1225)
  fix: Add error handling for missing dependencies (fixes #1210) (#1232)
  [documdocs:  deploy docsify in docker. (#1241)
  docs: Add embed gist instructions to Embed Files (fixes #932 ) (#1238)
  chore: add changelog 4.11.4
  [build] 4.11.4
  feat: added html sanitizer for remote rendering (#1128)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@trusktr trusktr

Labels
build This is related to build process ready to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1210 - Add error handling for missing dependencies MLH-Fellowship/docsify
2 participants
@trusktr @mohammedsahl