Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release 4.8.0 break things, e.g. https://jhildenbiddle.github.io/docsify-tabs tab doesn't work any more. #663

Closed
dryruner opened this issue Oct 31, 2018 · 9 comments
Labels
bug confirmed as a bug

Comments

@dryruner
Copy link

No description provided.

@dryruner
Copy link
Author

Also, if I'd like to download and import docsify.min.js@4.7.1, where could I find it?

@QingWei-Li QingWei-Li added the bug confirmed as a bug label Oct 31, 2018
@dryruner
Copy link
Author

Also, if I'd like to download and import docsify.min.js@4.7.1, where could I find it?

Reply myself in case this is useful to others:
Use
<script src="https://unpkg.com/docsify@4.7.1/lib/docsify.min.js"></script>
Instead of
<script src="https://unpkg.com/docsify/lib/docsify.min.js"></script>

@QingWei-Li
Copy link
Member

QingWei-Li commented Oct 31, 2018

👆Cool! You first found a workaround.
You can specify the version number, for example

<script src=//unpkg.com/docsify@4.7.0></script>

I will check it.

@dryruner
Copy link
Author

Thanks!

@QingWei-Li
Copy link
Member

fixed in 4.8.1

@QingWei-Li
Copy link
Member

QingWei-Li commented Nov 1, 2018

@jhildenbiddle

This DOM has changed and caused docsify-tab to not work, can you fix it?
Now all html code inline elements will be in the p tag.(This is a bug before marked and has now been fixed.) So button will also be in the p tag.

https://github.com/markedjs/marked/blob/f1ddca7febad16eb7861af0a7135989df0eb8e80/lib/marked.js#L59-L64

I was compatible with this issue in 4.8.1, but I found that it caused other bugs #677, so I rolled back it.

@QingWei-Li QingWei-Li reopened this Nov 1, 2018
@jhildenbiddle
Copy link
Member

jhildenbiddle commented Nov 1, 2018

Fixed in docsify-tabs 1.0.6.

Thanks for the heads up, @QingWei-Li!

@QingWei-Li
Copy link
Member

You are right. I reread the marked source code, it does not wrap the block-level elements.

@jhildenbiddle
Copy link
Member

Hehe...

That's why I deleted my comment about wrapping all HTML in a <p>. Turns out <button> tags are wrapped, but not all HTML. 😄

vdloo added a commit to ByteInternet/community.hypernode.io that referenced this issue Jan 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug confirmed as a bug
Projects
None yet
Development

No branches or pull requests

3 participants