Skip to content

Fix #1007 - Undefined error in search #1008

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

Neatoro
Copy link
Contributor

@Neatoro Neatoro commented Jan 16, 2020

fixes #1007

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:


  • DO NOT include files inside lib directory.

@Neatoro Neatoro requested a review from QingWei-Li January 16, 2020 09:32
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🙏

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🙏

@Neatoro Neatoro removed the request for review from QingWei-Li January 17, 2020 08:29
@Neatoro
Copy link
Contributor Author

Neatoro commented Jan 17, 2020

I am currently seeing some issues in the checks, but they are not happing on my local machine. The linting seems also be caused by files that I did not touch.

@anikethsaha
Copy link
Member

Thats fine, i will resolve it in future. Don't worry your PR is fine. I just need to make some changes then I will merge it.

@Neatoro
Copy link
Contributor Author

Neatoro commented Jan 17, 2020

@anikethsaha Thank you very much! Sounds great!

@anikethsaha
Copy link
Member

@Neatoro could you please rebase...

@sy-records
Copy link
Member

@anikethsaha I also have this problem, when will it be fixed?

@anikethsaha
Copy link
Member

It will be released soon

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search does not work with deeply nested file structure
4 participants