Skip to content

action: refactor config vercel and pages publish. #2317

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 41 commits into from
Closed

action: refactor config vercel and pages publish. #2317

wants to merge 41 commits into from

Conversation

Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Dec 3, 2023 •
edited
Loading

Summary

Redirect output root path to docs/index.html since we remove the root index.html under #2316 .
If it is acceptable, we could merge it into #2316 and move on.

Update:
Custom github-pages publish flow to adapt index.html changes.

Related issue, if any:

What kind of change does this PR introduce?

Repo settings

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
    Non core functions related changes.

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 9:16am

@Koooooo-7 Koooooo-7 mentioned this pull request Dec 3, 2023
Merged
2 tasks
@Koooooo-7 Koooooo-7 marked this pull request as ready for review December 3, 2023 11:45
sy-records
sy-records previously requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is not without preview. use cdn resources instead of lib.

@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Dec 3, 2023 •
edited
Loading

But it is not without preview. use cdn resources instead of lib.

Because we import the CND resources in index.html.
I gonna update it.

@Koooooo-7 Koooooo-7 requested a review from sy-records December 3, 2023 12:25
@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Dec 3, 2023 •
edited
Loading

It works with local resources now.

@sy-records sy-records marked this pull request as draft December 4, 2023 08:25
@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Dec 4, 2023 •
edited
Loading

Update:
The pages branch gh-pages for publish (GithubPages branch).
Github Action: deploy-gh
Rewrite result: index.html
(Copy /lib action is similar operations)

@Koooooo-7 Koooooo-7 marked this pull request as ready for review December 4, 2023 08:29
@Koooooo-7 Koooooo-7 marked this pull request as draft December 4, 2023 08:37
@Koooooo-7 Koooooo-7 changed the title chore: config vercel. action: refactor config vercel and pages publish. Dec 4, 2023
@Koooooo-7 Koooooo-7 marked this pull request as ready for review December 4, 2023 09:55
@jhildenbiddle
Copy link
Member

@Koooooo-7 --

I've addressed the Vercel deployment issue in #2316.

Base automatically changed from replace-live-server to develop December 11, 2023 21:00
@Koooooo-7 Koooooo-7 mentioned this pull request Dec 12, 2023
Closed
@jhildenbiddle jhildenbiddle mentioned this pull request Dec 21, 2023
Merged
4 tasks
@sy-records sy-records deleted the pr-2316 branch December 22, 2023 05:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sy-records sy-records sy-records left review comments

@jhildenbiddle jhildenbiddle Awaiting requested review from jhildenbiddle

@trusktr trusktr Awaiting requested review from trusktr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Koooooo-7 @jhildenbiddle @sy-records