Skip to content

fix: prevent unnecessary themeColor deprecation notice #2403

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

jhildenbiddle
Copy link
Member

Summary

The following deprecation warning was spamming the console even when $docsify.themeColor was not being used:

$docsify.themeColor is deprecated. Use a --theme-color property in your style sheet. Example:
<style>
  :root {
    --theme-color: deeppink;
  }
</style>

This console message will now only appear when $docsify.themeColor is used.

Related issue, if any:

None

What kind of change does this PR introduce?

Bugfix

For any code change,

N/A

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview Apr 11, 2024 3:08pm

@jhildenbiddle jhildenbiddle self-assigned this Apr 11, 2024
@jhildenbiddle jhildenbiddle added this to the 5.x milestone Apr 11, 2024
@jhildenbiddle jhildenbiddle requested a review from a team April 12, 2024 14:17
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Koooooo-7 Koooooo-7 requested a review from a team April 13, 2024 04:16
@sy-records sy-records merged commit a3ab2be into develop Apr 13, 2024
9 checks passed
@sy-records sy-records deleted the fix-themecolor-deprecation-notice branch April 13, 2024 04:17
@sy-records sy-records mentioned this pull request May 5, 2025
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants