Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Logger.php #235

Closed
wants to merge 1 commit into from
Closed

Update Logger.php #235

wants to merge 1 commit into from

Conversation

cobaltjeh
Copy link

The Symfony LoggerInterface is deprecated, that class hints that the PsrLogger should be used instead.

The Symfony LoggerInterface is deprecated, that class hints that the PsrLogger should be used instead.
@stof
Copy link
Member

stof commented Mar 25, 2014

@jmikola note that this change will bump the Symfony requirement to 2.3+ (Symfony was not relying on PSR-3 before 2.3) so the composer constraint should be updated when merging

@jmikola
Copy link
Member

jmikola commented Mar 28, 2014

@stof: Thanks for the heads up.

@jmikola
Copy link
Member

jmikola commented Mar 28, 2014

@stof: If I understand correctly, since our 2.0 release is only compatible with Symfony 2.0, and the 3.0 (currently master branch) is compatibly with ~2.1, merging this would mean we'd have no release with support for 2.1.x and 2.2.x. I think the correct thing to do would be slate this for a 4.0.0 milestone to be merged after we tag a 3.0.0 release (which is waiting on ODM 1.0.0). Does that make sense?

@jmikola jmikola added this to the 4.0.0 milestone Mar 28, 2014
@stof
Copy link
Member

stof commented Mar 28, 2014

@jmikola IMO, the best solution would be to copy this logger to the ODM itself with a PSR-3 typehint (it is not specific to Symfony2 anymore), and keep the existing class as is but marking it deprecated. This way, the bundle can choose the right class depending on the version, users of the ODM have a PSR-3 logger available by default, and you don't need a 4.0 milestone yet

@jmikola
Copy link
Member

jmikola commented Mar 28, 2014

@stof: That sounds like a great idea. Thanks!

@jmikola jmikola modified the milestones: 3.0.0, 4.0.0 May 16, 2014
@jmikola jmikola modified the milestones: 3.0.0, 3.0.0-BETA5 May 19, 2014
@malarzm malarzm modified the milestones: 3.0.0, 3.1 May 22, 2015
@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2015

Closing this in favor of #323. The upcoming 3.1 version will bump Symfony requirement to 2.3+.

@alcaeus alcaeus closed this Dec 4, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants