Fix type guesser. Ignore field MappingException. #458
Conversation
Form/DoctrineMongoDBTypeGuesser.php
Outdated
| @@ -49,6 +49,10 @@ public function guessType($class, $property) | |||
|
|
|||
| list($metadata, $name) = $ret; | |||
|
|
|||
| if (!$metadata->hasField($property)) { | |||
There was a problem hiding this comment.
@malarzm Done. But in code there are only 3 places with such style. And 22 without spaces
There was a problem hiding this comment.
Ah so the bundle did not receive CS fixes yet, thank you :)
Form/DoctrineMongoDBTypeGuesser.php
Outdated
| @@ -49,6 +49,10 @@ public function guessType($class, $property) | |||
|
|
|||
| list($metadata, $name) = $ret; | |||
|
|
|||
| if (! $metadata->hasField($property)) { | |||
| return new TypeGuess($this->typeFQCN ? TextType::class : 'text', [], Guess::LOW_CONFIDENCE); | |||
There was a problem hiding this comment.
Now I saw the test I'm wondering whether guessing TextType (even with low confidence) is correct. From what I saw in https://symfony.com/doc/current/form/type_guesser.html it's possible to just return; if we can't (or shouldn't) make a guess at all. Do you think it'd be more appropiate?
There was a problem hiding this comment.
I copy behaviour from a symfony/doctrine-bridge. Looks like in the first versions guessType returns only TypeGuess instance (based on phpDoc). I think now we can return nulls
There was a problem hiding this comment.
@malarzm Do you want me to change it?
There was a problem hiding this comment.
Also if you could squash commits later that'd be awesome :)
|
@malarzm ping! Is there any other things that prevent merging? |
|
Sorry, had this email starred but did not get back to it in time. Looks good to me! @alcaeus are we couting this as a bugfix and releasing 3.4.3 or will this wait for 3.5.0? |
|
FWIW I'm fine with relasing 3.4.3 with this fix only as we do not get that many issues to fix. |
|
Bugfix it is. |
|
@BoShurik enjoy 3.4.3 ;) |
Fix errors like "No mapping found for field 'plainPassword' in class 'App\Document\Administrator'."