Don't generate proxy classes for embedded documents #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Aug 11, 2017
| @@ -62,7 +63,9 @@ protected function execute(Console\Input\InputInterface $input, Console\Output\O | |||
| { | |||
| $dm = $this->getHelper('documentManager')->getDocumentManager(); | |||
|
|
|||
| $metadatas = $dm->getMetadataFactory()->getAllMetadata(); | |||
| $metadatas = array_filter($dm->getMetadataFactory()->getAllMetadata(), function (ClassMetadata $classMetadata) { | |||
| return !$classMetadata->isEmbeddedDocument; | |||
There was a problem hiding this comment.
I think we should also exclude $classMetadata->isQueryResultDocument while we're here (and maybe $classMetadata->isMappedSuperclass too)?
There was a problem hiding this comment.
I'll just change the check to isDocument, that's simpler. I'll have to think about isQueryResultDocument - there may be the need for proxies there.
There was a problem hiding this comment.
Updated. Turns out we don't have isDocument, so I can't test against that. We also don't need to generate proxies for query result documents, so I'll add that when merging down to master. 👍
I wouldn't worry too much here, it's only commands ;) |
alcaeus
force-pushed
the
no-proxy-embedded-documents
branch
from
fd6112f to
7e96bba
Compare
jmikola
approved these changes
Aug 14, 2017
This was referenced Aug 17, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1627.
Not sure about tests here, but it fixes the issue.