[Removed strict xml validation] #2535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
requested changes
May 29, 2023
| @@ -681,7 +681,7 @@ private function validateSchema(string $filename): void | |||
| libxml_clear_errors(); | |||
|
|
|||
| if (! $document->schemaValidate(__DIR__ . '/../../../../../../doctrine-mongo-mapping.xsd')) { | |||
| throw MappingException::xmlMappingFileInvalid($filename, $this->formatErrors(libxml_get_errors())); | |||
| return; | |||
There was a problem hiding this comment.
This removes feature altogether instead of letting user opt-out of it. There should be a flag passed to XmlDriver::__construct that defaults to true so current behaviour is preserved.
Also version 2.2.x that you're targeting is no longer maintained. This technically is a feature so 2.6.x branch should be targeted although we may consider releasing as a bugfix version (depending on where we'll end with configurating opt-out).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed strict xml validation. Before due this not able to use external gedmo extension.
#2529