add enum reflection property

[IonBazan]

Reduces code duplication in doctrine/mongodb-odm#2412 and doctrine/orm#9304 by extracting the EnumReflectionProperty here. Please take note of slightly changed name and throwing native ValueException here instead of MappingException.

[greg0ire]

throwing native ValueException here instead of MappingException.

I think you mean ValueError. Besides, since doctrine/persistence has its own MappingException class, why not preserve the original behavior and wrap the ValueError in it?

[malarzm]

I think you mean ValueError. Besides, since doctrine/persistence has its own MappingException class, why not preserve the original behavior and wrap the ValueError in it?

I'd say MappingException is for mapping errors :) I'm perfectly fine letting ValueError be thrown, for instance in ODM we'll catch it and wrap in our HydratorException: doctrine/mongodb-odm#2412 (comment)

[greg0ire]

@malarzm I wasn't worried so much about preserving the type, which wouldn't even be achieved by my proposal, as about preserving the extra context that is added:

Context: Trying to hydrate enum property "%s::$%s"
Problem: Case "%s" is not listed in enum "%s"
Solution: Either add the case to the enum type or migrate the database column to use another case of the enum

If you have many entities/document using the same enum, and your database/document store contains an invalid value for that enum somewhere, it might help to know where.

HydratorException does seem like a better type for this, maybe we should introduce something similar in doctrine/persistence?

[malarzm]

We'll totally do what you're proposing, but on ODM's level. I'm not sure how much value the exception will bring in this case. For instance in ODM the HydratorException is already extending our base exception and we can't change that. So we'd need to catch the new exception and later transform it into our one. Not sure if it's worth it :)

[greg0ire]

Thanks @IonBazan !