Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conflict between _.partition in Underscore and contrib #115

Closed
joshuacc opened this issue Feb 3, 2014 · 4 comments
Closed

Conflict between _.partition in Underscore and contrib #115

joshuacc opened this issue Feb 3, 2014 · 4 comments
Labels

Comments

@joshuacc
Copy link
Contributor

joshuacc commented Feb 3, 2014

Underscore recently added a partition method which conflicts with the one in contrib. jashkenas/underscore#1430

I haven't had a chance to look into it very much, but we should figure out a way to resolve the conflict.

@locks
Copy link
Contributor

locks commented Feb 3, 2014

While a rename would probably be the easiest way to go about it, I'd just like to note that there is a similarly proposed _.groupsOf, which includes a comment by @fogus himself.

@joshuacc
Copy link
Contributor Author

@fogus I'm guessing renaming our current partition is the way to go. Have a preference on a new name so I can get a fix in?

@joshuacc
Copy link
Contributor Author

For now I've gone with _.chunk and _.chunkAll since that seemed the clearest to me when accounting for both methods.

@fogus
Copy link
Member

fogus commented Feb 23, 2014

I like those names. Thanks Joshua.

On Saturday, February 22, 2014, Joshua Clanton notifications@github.com
wrote:

For now I've gone with _.chunk and _.chunkAll since that seemed the
clearest to me when accounting for both methods.


Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-35815191
.

-- http://blog.fogus.me

-- http://github.com/fogus

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants