Replace nix with a devcontainer #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
reviewed
Nov 4, 2024
| ENV NODE_PATH /usr/lib/node_modules | ||
|
|
||
| # Install dependencies | ||
| RUN <<EOF |
There was a problem hiding this comment.
This will create only a single layer in the file system? If so, I think going forward our other images can also adopt this style instead of adding everything to a single command. It is much more readable.
There was a problem hiding this comment.
Yes this only creates a single layer. And I approve of this.
Co-authored-by: Bart Mesuere <mesuerebart@gmail.com>
No I will remove the file from our images repo. I have added the build deploy step here, so we only need the file in a single location |
bmesuere
approved these changes
Nov 5, 2024
…judge into chore/devcontainer
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces
nixandpoetryas package management systems with a devcontainer.The devcontainer builds the production docker image, and then adds git support and development dependencies to it.
For ease of development I moved the production dockerfile to this repo as well. This means that dependencies can be added to it or updated while developing. Merging a pr will build the docker image, making sure the docker image is always up to date with the latest TESTed version of the code.
I also restructured the docker file, such that it is clearer which dependency is required by which language. I hope this improves maintainability.
To avoid duplication
nix,poetryanddependencies.mdare all removed. The docker image is now the single source of truth for all production package versions. Dev dependencies should be specified indev-dependencies.sh.The README is also updated to reflect these changes.
The solution is still not ideal as updating the dependencies is still a manual job and dependabot is not able to work with docker deps. We might consider adding some custom system as proposed here in a later stage: dependabot/dependabot-core#2129 (comment)