Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SimpleQuery: only call data.sort if we have some sort criteria #241

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Apr 9, 2020

SimpleQuery: only call data.sort if we have some sort criteria

Calling Array#sort with empty sort criteria is a waste of resources and worse, depending on the sort implementation may actually re-order items.

Fixes #159

@msssk msssk merged commit e59daa3 into dojo:master Apr 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleQuery._createSortQuerier sort comparator function is incorrect
1 participant