Undefining a module no longer undefines special modules, issue #128

[rorticus]

Type: bug

The following has been addressed in the PR:

• There is a related issue
• All code matches the style guide
• Unit or Functional tests are included in the PR

Description:

Fix for undefining modules that have dependencies on require, exports, or module. These special modules should never be undefined!

Resolves #128

[codecov]

Codecov Report

Merging #130 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   85.58%   85.63%   +0.05%     
==========================================
  Files           1        1              
  Lines         548      550       +2     
  Branches      136      137       +1     
==========================================
+ Hits          469      471       +2     
  Misses         32       32              
  Partials       47       47

Impacted Files	Coverage Δ
_build/src/loader.ts	85.63% <0%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0fcf...b619a26. Read the comment docs.

[kitsonk]

Only thought I have, do we want to preserve/guard ourselves against someone doing require.undef('require')? Maybe that is just being paranoid.

[rorticus]

Yeah I thought about that. I'm not sure where the line is on how much we should be protect people from doing something ... questionable.

[kitsonk]

Yeah, I guess this meets the scope of the issue and we shouldn't allow me to scope creep us!