Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Un-hardcode the master branch in plugin updates #141

Merged
merged 6 commits into from
May 18, 2024

Conversation

mattmess1221
Copy link
Contributor

@mattmess1221 mattmess1221 commented Mar 26, 2024

Fixes #71

My experience with Go is minimal, and I wasn't able to get the go-bindata generated code to create a reasonable diff, so I did not include that. It's included as a separate commit.

@josegonzalez
Copy link
Member

Do you mind adding a unit test? I've created a main branch on the smoke-test-plugin here.

Tests are available here: https://github.com/dokku/plugn/blob/master/tests/functional/tests.sh.

I'll take a look and see if we can replace go-bindata with go:embed, which should make developing easier.

@mattmess1221
Copy link
Contributor Author

mattmess1221 commented Mar 26, 2024 via email

@josegonzalez
Copy link
Member

Gotcha. I can make a new repo that simulates that then.

@josegonzalez
Copy link
Member

I created the plugin here: https://github.com/dokku/smoke-test-plugin-main

Mind updating tests to use this branch?

@mattmess1221
Copy link
Contributor Author

Can you push some tags to that repo?

@josegonzalez
Copy link
Member

I've pushed all the tags up to that repo

@josegonzalez
Copy link
Member

Mind rebasing onto main and checking on what the test error is about?

@mattmess1221 mattmess1221 force-pushed the fix/update-with-main-branch branch from ea27f89 to 8487bc3 Compare May 18, 2024 16:04
@mattmess1221 mattmess1221 force-pushed the fix/update-with-main-branch branch from 8487bc3 to 1dcb0e9 Compare May 18, 2024 16:07
@josegonzalez josegonzalez merged commit 54b916c into dokku:main May 18, 2024
3 checks passed
@mattmess1221 mattmess1221 deleted the fix/update-with-main-branch branch May 18, 2024 23:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin using 'main' default branch ends up in error during plugn update
2 participants