-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Un-hardcode the master branch in plugin updates #141
Un-hardcode the master branch in plugin updates #141
Conversation
Do you mind adding a unit test? I've created a Tests are available here: https://github.com/dokku/plugn/blob/master/tests/functional/tests.sh. I'll take a look and see if we can replace |
I'll get right on that.
Although, that plugin won't be effective to test this. It's not the
existence of main that's the issue, but the absence of master.
…On Tue, Mar 26, 2024, 5:09 PM Jose Diaz-Gonzalez ***@***.***> wrote:
Do you mind adding a unit test? I've created a main branch on the
smoke-test-plugin here
<https://github.com/dokku/smoke-test-plugin/tree/main>.
Tests are available here:
https://github.com/dokku/plugn/blob/master/tests/functional/tests.sh.
I'll take a look and see if we can replace go-bindata with go:embed,
which should make developing easier.
—
Reply to this email directly, view it on GitHub
<#141 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AQKUID4SC3UWJ2XBASO3Y2HPZLAVCNFSM6AAAAABFJTYXMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGQ3TSMZWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Gotcha. I can make a new repo that simulates that then. |
I created the plugin here: https://github.com/dokku/smoke-test-plugin-main Mind updating tests to use this branch? |
Can you push some tags to that repo? |
I've pushed all the tags up to that repo |
Mind rebasing onto main and checking on what the test error is about? |
ea27f89
to
8487bc3
Compare
8487bc3
to
1dcb0e9
Compare
Fixes #71
My experience with Go is minimal, and I wasn't able to get the go-bindata generated code to create a reasonable diff,
so I did not include that.It's included as a separate commit.