Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix: Hide section edit buttons if flag noeditbtn is set #196

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Bugfix: Hide section edit buttons if flag noeditbtn is set #196

merged 1 commit into from
Jul 8, 2016

Conversation

micgro42
Copy link
Contributor

Dokuwiki usually adds editbuttons for every (sub-)section of the included page. This may not be the desired behavior for included pages and is counterintuitive if the flag noeditbutton is set.

closes #145

@michitux
Copy link
Member

michitux commented Jul 8, 2016

For me, section edits were always a different feature than the edit button for the whole included page, but I agree that probably users will see this differently. This differentiation probably also comes from the fact that while the edit button for the whole page always existed, support for nested section edit buttons was added much later. I will merge this now and see if people will like it. If there are any problems with this (like people wanting section edit buttons but no global edit button) creating a separate flag for that might also be an option (but I think there are already more than enough flags...).

@michitux michitux merged commit fd6eee9 into dokufreaks:master Jul 8, 2016
@micgro42 micgro42 deleted the bugfix/removeSectionEditButtons branch July 9, 2016 16:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firstseconly, noeditbtn and nofooter don't combine
2 participants