Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test in PHP 8.2 #22

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Test in PHP 8.2 #22

merged 1 commit into from
Jan 11, 2023

Conversation

donatj
Copy link
Owner

@donatj donatj commented Nov 24, 2022

No description provided.

@h1nds1ght
Copy link

Not sure if it is already addressed, but I have a deprecation notice on 8.1 for strftime in SimpleCalendar::weekdays(), see i.e. https://php.watch/versions/8.1/strftime-gmstrftime-deprecated.

Currently I use this fix:

 			$today = (86400 * (date('N')));
 			$wDays = [];
 			for( $n = 0; $n < 7; $n++ ) {
-				$wDays[] = strftime('%a', time() - $today + ($n * 86400));
+				$wDays[] = date('D', time() - $today + ($n * 86400));
 			}
 		}

@donatj donatj merged commit 764793f into master Jan 11, 2023
@donatj donatj deleted the 8_2 branch January 11, 2023 18:29
@donatj
Copy link
Owner Author

donatj commented Jan 11, 2023

Thanks, @h1nds1ght - I fixed it and finally got around to tagging a release https://github.com/donatj/SimpleCalendar/releases/tag/v0.7.0 (it'd been a very long time)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants