Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Timing Issue When Attaching Certain Devices #659

Closed
RedTail72 opened this issue Jul 20, 2023 · 10 comments · Fixed by #677
Closed

Timing Issue When Attaching Certain Devices #659

RedTail72 opened this issue Jul 20, 2023 · 10 comments · Fixed by #677

Comments

@RedTail72
Copy link

When testing with 2 SanDisk USB storage devices, they fail to attach with error message usbip: error: Attach Request for 3-13 failed - Device in error state.

Cloning down the project locally, I was able to run it locally in debug mode. On my first run, I set a breakpoint in GetVBoxDevice and found deviceInterfaces was empty (which explained the error). I decided to step farther back and set a breakpoint in Get_Device_Interface_List. When I set it there, I found the list was populated for each call into the method. It was a little slower, so I'm guessing it has something to do with the device driver being replaced.

Opening as a separate issue for easier tracking, based on the conversation from #425 (comment).

Output from server logs:

dbug: Usbipd.Server[1000]
      new connection from 192.168.29.148
dbug: Usbipd.Server[1000]
      connection close: Unable to read beyond the end of the stream.
dbug: Usbipd.Server[1000]
      connection closed
dbug: Usbipd.Server[1000]
      new connection from 192.168.29.148
dbug: Usbipd.ConnectedClient[1000]
      Received opcode: OP_REQ_IMPORT
fail: Usbipd.ConnectedClient[3]
      An exception occurred while communicating with the client:
      System.IO.FileNotFoundException: Unable to find the specified file.
         at Usbipd.ConfigurationManager.GetVBoxDevice(BusId) in D:\a\usbipd-win\usbipd-win\Usbipd\ConfigurationManager.cs:line 308
         at Usbipd.VBoxUsb.ClaimDeviceOnce(BusId) in D:\a\usbipd-win\usbipd-win\Usbipd\VBoxUsb.cs:line 66
         at Usbipd.VBoxUsb.ClaimDevice(BusId) in D:\a\usbipd-win\usbipd-win\Usbipd\VBoxUsb.cs:line 87
         at Usbipd.VBoxUsb.ClaimDevice(BusId) in D:\a\usbipd-win\usbipd-win\Usbipd\VBoxUsb.cs:line 87
         at Usbipd.ConnectedClient.HandleRequestImportAsync(CancellationToken) in D:\a\usbipd-win\usbipd-win\Usbipd\ConnectedClient.cs:line 167
         at Usbipd.ConnectedClient.HandleRequestImportAsync(CancellationToken) in D:\a\usbipd-win\usbipd-win\Usbipd\ConnectedClient.cs:line 270
         at Usbipd.ConnectedClient.RunAsync(CancellationToken) in D:\a\usbipd-win\usbipd-win\Usbipd\ConnectedClient.cs:line 58
dbug: Usbipd.Server[1000]
      connection close: Unable to find the specified file.
dbug: Usbipd.Server[1000]
      connection closed
This was referenced Jul 20, 2023
Closed
Closed
@dorssel
Copy link
Owner

dorssel commented Aug 14, 2023

@RedTail72
Received the device in good order. Will keep you updated as soon as I have some results. Thanks!

@dorssel dorssel mentioned this issue Aug 16, 2023
Merged
@dorssel
Copy link
Owner

dorssel commented Aug 16, 2023

@RedTail72
Could you test your (other) devices with the build artifact from #677 ? The installer is here: https://github.com/dorssel/usbipd-win/actions/runs/5879219313?pr=677. Note that the installer is not signed, but the drivers are.

It fixes the issue (which was very reproduceable) with the SanDisk Ultra you sent me.

@thijsputman
Copy link

@dorssel, could this potentially also impact #458?

I'm still occasionally running into that issue...

@dorssel
Copy link
Owner

dorssel commented Aug 17, 2023

@thijsputman
It could be, but I don't think so. The SanDisk issue is that the device locks up, not the driver. In your YubiKey case it is the driver that fails to load; the device is still responsive as in "it appears in the device list" (right?). With SanDisk, the entire device disappears until replug.

@thijsputman
Copy link

Correct; the device itself doesn't appear to lock up in my case – I'll keep an eye on this issue nonetheless.

@RedTail72
Copy link
Author

RedTail72 commented Aug 18, 2023 via email

@RedTail72
Copy link
Author

RedTail72 commented Aug 21, 2023 via email

@RedTail72
Copy link
Author

@RedTail72 Could you test your (other) devices with the build artifact from #677 ? The installer is here: https://github.com/dorssel/usbipd-win/actions/runs/5879219313?pr=677. Note that the installer is not signed, but the drivers are.

It fixes the issue (which was very reproduceable) with the SanDisk Ultra you sent me.

@dorssel I have tested the build artifact you linked to and was able to mount the SanDisk drive without any issues. I confirmed expected confirmed behavior with another previously validated USB drive as well.

From my perspective, this looks good and resolves this issue.

@dorssel
Copy link
Owner

dorssel commented Aug 28, 2023

@RedTail72
I've merged the change. GitHub auto-closed the issue. You can use the dev version until I make a new release.

Do you have a return address for the SanDisk, or do you want me to keep it for regression testing?

@RedTail72
Copy link
Author

RedTail72 commented Aug 28, 2023 via email

This was referenced Dec 27, 2023
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix port reset timing dorssel/usbipd-win
3 participants
@thijsputman @RedTail72 @dorssel