Update error messages for FURB108 and FURB124: #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FURB108 and FURB124 both deal with binary operators composed of 2 comparison exprs. Before the operands where assumed to always be in the same order, which meant that the placeholder variables did not line up with the names in the source code. Now they do!
This is the third time that Mypy has failed on CI, but not on my local machine: A bug is running amok and must be exterminated. Maybe I will do that tomorrow.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FURB108 and FURB124 both deal with binary operators composed of 2 comparison exprs. Before the operands where assumed to always be in the same order, which meant that the placeholder variables did not line up with the names in the source code. Now they do!
Closes #117