Require len() comparison check to only operate within if statements
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this check picked up on cases which might cause a different value or type to be returned if the suggestion was blindly applied. The assumption was that you would be doing this in a boolean context, such as an `if` block, which would handle the truthy value correctly. Now this check only checks code inside of an `if` statement (including match guards, "if" sections of list generators, and so on).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this check picked up on cases which might cause a different value or type to be returned if the suggestion was blindly applied. The assumption was that you would be doing this in a boolean context, such as an
ifblock, which would handle the truthy value correctly. Now this check only checks code inside of anifstatement (including match guards, "if" sections of list generators, and so on).Closes #31