-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow customization for extensions type #6969
Conversation
This introduces a new configuration for the `graphql-request` plugin for typescript. It allows to use `unknown` (or a custom type) instead of `any` for the `extensions` parameter without breaking changes.
🦋 Changeset detectedLatest commit: 69a99bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/Lu4eeBupQDbf8nhaXyT56X6kuMyT |
@dodomorandi Can you please create a changeset that describes this change? See #6969 (comment) |
Thanks @n1ru4l for the feedback! Let me know if you want me to squash the commits (now or later). |
@dodomorandi Sorry one more thing, could you add a very simple test for verifying that this option does not break in the future? 😇 No worries about squashing, I will do that during the merge! |
No problem! I was doubtful just because it will be more complex the test than the actual feature 😁. I am going to add the test and update the checklist. |
@dodomorandi The downside of having lots of options is that you can sometimes break them without noticing 😆 Which unfortunately happened a lot lately. |
@dodomorandi Awesome thank you! |
Description
This introduces a new configuration for the
graphql-request
plugin fortypescript. It allows to use
unknown
(or a custom type) instead ofany
for theextensions
parameter without breaking changes.Related dotansimha/graphql-code-generator-community#156
Type of change
How Has This Been Tested?
No jest tests has been added for this. The change is trivial, but if you want me to add a test, just say it.
Checklist: