Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Obsolete ClientSide #1266

Closed
granicz opened this issue Sep 30, 2022 · 2 comments
Closed

Obsolete ClientSide #1266

granicz opened this issue Sep 30, 2022 · 2 comments
Assignees
@Jand42
Labels
6.0.3.237 enhancement

Comments

@granicz
Copy link
Member

granicz commented Sep 30, 2022

The auto-opened WebExtensions module contains ClientSide, an alias for InlineControl. This function was rarely if ever used, and with the ongoing effort to provide a quotation-free syntax across the entire API, this should now be moved to InlineControl as a new constructor (carry over the comment to it) and marked to auto-quote, leaving the original function marked as obsolete.
@granicz
Copy link
Member Author

granicz commented Sep 30, 2022

Be sure to copy the code comment as well to the new constructor.

Jand42 added a commit that referenced this issue Oct 1, 2022
@Jand42
#1266 obsolete ClientSide
18d2511
Jooseppi12 added a commit that referenced this issue Oct 3, 2022
@Jooseppi12
#1266 #1267 : JavaScript attribute for constructor parameter, remove …
68b75cf 
…InlineControl.Create and use constructor instead
Jand42 pushed a commit that referenced this issue Oct 3, 2022
@Jooseppi12
#1266 #1267 JavaScript attribute for constructor parameter
bf9ee13 
remove InlineControl.Create and use constructor instead
@Jand42
Copy link
Member

Jand42 commented Oct 3, 2022

Now obsoleted in favor of InlineControl constructor call: new WebSharper.Web.InlineControl(expr) (new keyword is optional for F#)

@Jand42 Jand42 closed this as completed Oct 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Jand42 Jand42

Labels
6.0.3.237 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jand42 @granicz