Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix source maps for offline sitelets #1307

Closed
Jand42 opened this issue Jan 5, 2023 · 0 comments
Closed

Fix source maps for offline sitelets #1307

Jand42 opened this issue Jan 5, 2023 · 0 comments
Assignees
@Jooseppi12
Labels
6.1.2.257 bug

Comments

@Jand42
Copy link
Member

Jand42 commented Jan 5, 2023 •
edited
Loading

This code

core/src/sitelets/WebSharper.Sitelets.Offline/Output.fs

Lines 201 to 202 in 4bba03a

File.AppendAllText(P.ToAbsolute st.Config.OutputDirectory sp,
"\n//# sourceMappingURL=" + mapFileName)

is appending //# sourceMappingURL=... to the map file instead of the js file as intended, needs fix for offline sitelets to work with source maps.
@Jand42 Jand42 added the bug label Jan 5, 2023
@granicz granicz mentioned this issue Jan 6, 2023
Merged
Jooseppi12 added a commit that referenced this issue Jan 9, 2023
@Jooseppi12
#1307
5c0b978
Jand42 pushed a commit that referenced this issue Jan 9, 2023
@Jooseppi12
#1307 Fix source maps for offline sitelets
01e0381 
* #1307

* Enable sourcemaps for StaticHtml.Tests project for testing
@Jand42 Jand42 closed this as completed Jan 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Jooseppi12 Jooseppi12

Labels
6.1.2.257 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jand42 @Jooseppi12