Skip to content

VS restart seems to be required #1311

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diegopego
Copy link
Contributor

VS restart seems to be required
After upgrading WebSharper nuget packages a reboot seems to be required on Windows 11 with Visual Studio 2022

Steps to reproduce:

  • dotnet new websharper-spa -lang f# -n MySPA
  • This application have some issue that I will try to fix by changing WebSharper.core
  • On my local WebSharper.core, I increment the version tag (I'm not sure if this is needed), make some modifications, and run the tests. When it's ok, I do a "build.cmd ws-package"
  • Update nuget packages on VS Gui, then "dotnet clean, dotnet run"
  • The MySpa issue persists.
  • I try: dotnet ws-stop, dotnet clean, dotnet run
  • The MySpa issue persists.
  • Restart Visual Studio 2022, dotnet clean, dotnet run, the issue is fixed.

VS restart seems to be required
After upgrading WebSharper nuget packages a reboot seems to be required on Windows 11 with Visual Studio 2022

Steps to reproduce:
- dotnet new websharper-spa -lang f# -n MySPA
- This application have some issue that I will try to fix by changing WebSharper.core
- On my local WebSharper.core, I increment the version tag (I'm not sure if this is needed), make some modifications, and run the tests. When it's ok, I do a "build.cmd ws-package"
- Update nuget packages on VS Gui, then "dotnet clean, dotnet run"
- The MySpa issue persists.
- I try: dotnet ws-stop, dotnet clean, dotnet run
- The MySpa issue persists.
- Restart Visual Studio 2022, dotnet clean, dotnet run, the issue is fixed.
@Jand42
Copy link
Member

Jand42 commented Jan 11, 2023

@diegopego A tip, to build a higher package version (build number increased) locally, you can run a set BUILD_NUMBER=XXX before the build.cmd CI-Release. Also run set WSPackageFolder=../localnuget if you want to run multiple builds like core->ui->templates

@diegopego
Copy link
Contributor Author

Could you please elaborate on the multiple builds?

@Jand42
Copy link
Member

Jand42 commented Jan 12, 2023

@diegopego If you have core+ui+templates checked out inside same root, also having a localnuget folder for local packages, you can do in a cmd:

set BUILD_NUMBER=300
set WSPackageFolder=../localnuget
set SKIP_CORE_TESTING=True

cd core
call build.cmd CI-Release

cd ../ui
call build.cmd CI-Release

cd ../templates
call build.cmd CI-Release

Because package update looks in ../localnuget by default for local builds. SKIP_CORE_TESTING=True is optional to make process quicker if you have confidence in test coverage.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants