3.1 update for gRPC-start tutorial and its two sample apps #18103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @CHOWYANYAN. Do you mean you need more information on:
|
|
@JamesNK, does this update look OK for 3.1? |
JamesNK
approved these changes
May 4, 2020
aspnetcore/tutorials/grpc/grpc-start/sample/GrpcGreeter/GrpcGreeter.csproj
Outdated
Show resolved
Hide resolved
Update per review feedback.
Reversing change that caused the merge issue.
Resolving merge conflict with mass no-loc for razor fix that occurred today.
Fixing per review.
Addressing merge conflict - ms.date line
Rick-Anderson
approved these changes
May 5, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Review - Tutorial: Create a gRPC client and server in ASP.NET Core
Fixes #18104
Updated for ASP.NET Core 3.1:
Completing this issue is a prerequisite to related issue #16467 which includes creating a new 3.1 version samples .zip for download and redirecting to this updated tutorial.