-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
.NET Core RC2 #187
Comments
Done ;) How to update your toolchain to RC2:
@mattwarren @AndreyAkinshin @ig-sinicyn guys please make sure to follow before pulling ;) Then remove all your bin(s) & artifacts folders Changes that I have introduced:
@AndreyAkinshin now there is no nuget package in artifacts, you can create it with |
Awesome! |
@adamsitnik, I installed all the programs, but I can't build BenchmarkDotNet..NETStandard,Version=1.5: |
@AndreyAkinshin |
|
@AndreyAkinshin Its weird... Could you go to project.json and add |
|
@AndreyAkinshin Everything is in place, but yet it does not work ;/ I have few ideas:
|
Same issue here. Build output. |
Try this dependency list for project.json in benchmarkdotnet for .netstandard 1.5 |
@Tornhoof
|
@Tornhoof thanks for the fix!! now the whole team can go RC2 ;) |
Woot, thanks @adamsitnik for all you hard work (plus @Tornhoof for the project.json tip). It's been a while since I was able to build BenchmarkDotNet in VS!!! |
BTW one extra thing, I've added some code like this to var consoleWidth = 80;
try
{
consoleWidth = Console.WindowWidth;
}
catch (IOException)
{
logger.WriteLine($"Unable to get the Console width, defaulting to {consoleWidth}");
} But I then get the following errors when running
Any ideas? (I know I could change the code to |
I have pushed the @Tornhoof workaround to the repo to get it working for all of you. @mattwarren I have no idea ;/ |
Great! Now I can build almost all the project. However, I still have troubles with BenchmarkDotNet.Samples.FSharp.Core:
|
@adamsitnik, can you also update BenchmarkDotNet.Samples? I can build this project but I can't run any of our samples. Also, |
@AndreyAkinshin This time it was easy. The Nuget.config file was missing some feeds. I have updated it, cleaned my package cache, restored all (990 MB) and run all sample for both classic and core and F#. Sorry for the trouble! And as for the launchSettings.json it's much more simple now: VS offers this out of the box, no need for the hacks (copying scripts and launchSettings) |
Thanks! However, |
@adamsitnik, Ok, it looks that everything works fine. I'm almost ready to publish new version. I have only one additional request: can you update README.md and DEVELOPING.md with useful information about Core-RC2? |
@AndreyAkinshin done! I have tested the RC2 support with a benchmarks for my DotNext talk. At least on Windows everything works great! |
Ok, great. I want to check once again all the environments and publish |
Update solution, tests, projects and the code
I am working on it now because I need it for some parts of my talk ;)
The text was updated successfully, but these errors were encountered: