set TreatWarningsAsErrors to true #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyAkinshin
approved these changes
Jan 23, 2022
AndreyAkinshin
previously requested changes
Jan 23, 2022
There was a problem hiding this comment.
All the CI builds are red because of the Pack command:
\NuGet.Build.Tasks.Pack.targets(221,5): error NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [C:\projects\benchmarkdotnet\src\BenchmarkDotNet\BenchmarkDotNet.csproj]
dotnet.exe : An error occurred when executing task 'Pack'.
At C:\projects\benchmarkdotnet\build.ps1:89 char:1
+ & dotnet run --project build/Build.csproj -- $args
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (An error occurr...ng task 'Pack'.:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
Error: .NET CLI: Process returned an error (exit code 1).
Command executed with exception: Error: .NET CLI: Process returned an error (exit code 1).
|
@AndreyAkinshin the CI is finally green. I am going to "dismiss" your review and merge it. I hope you don't mind. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyAkinshin we currently have zero warnings (after #1896). I think that we should consider setting
TreatWarningsAsErrorsto true to prevent from new code issues being added. What do you think?