Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Update RepoToolset to 1.0.0-beta-62615-02 #96

Closed
wants to merge 1 commit into from
Closed

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 15, 2018

No description provided.

@tmat
Copy link
Member Author

tmat commented Feb 15, 2018

@tannergooding @livarcocc We are switching all repos to SHA256. See dotnet/roslyn#24820 for background.

Copy link
Contributor

@livarcocc livarcocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI turns green. There seems to be some regression on non-windows builds. This is the second repo where this change is failing for non-windows.

@tmat
Copy link
Member Author

tmat commented Feb 15, 2018

@livarcocc Yes, we need to update dotnet CLI to later version that has compilers that support signing on non-Windows. This repo has a build time dependency on CLI 1.1.4. Any reason not to update to 2.1.100-preview-007366?

@tannergooding
Copy link
Member

Updating the version of the SDK we build with should be fine. You will need to update the build.ps1 and build.sh to also install the 1.1 shared framework, however. (Compare https://github.com/dotnet/dotnet-cli-archiver/blob/master/build/build.ps1 with https://github.com/dotnet/CliCommandLineParser/blob/master/build/build.ps1)

@tmat
Copy link
Member Author

tmat commented Feb 27, 2018

@tannergooding Could you follow up on this?

@tmat tmat closed this Apr 5, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants