-
Notifications
You must be signed in to change notification settings - Fork 2k
Update wpf.md #2235
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update wpf.md #2235
Conversation
Add notice for .NET Framework.
Fix EF Core link
Second attempt to fix EF Core docs link
> | ||
> This document covers databinding for WPF on the .NET Framework. For WPF on .NET Core, please refer to the [EF Core documentation](~ef/core). | ||
> This document describes databinding for WPF on the .NET Framework. If your app is built with .NET Core, please refer to the [EF Core documentation](~/ef/core). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is right. Is using EF Core (as opposed to EF6 on .NET Core) going to help here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to word this? Our guidance for new .NET Core projects is to use EF Core, right? We can look separately at having a databinding section there, but I'm assuming either new projects (EF6 + .NET Framework) will make sense, OR they may be porting existing EF6 code from .NET Framework to .NET Core in which case this document is irrelevant (because it is a file->new experience).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajcvickers I revised the language to reference #778
Add issue reference
Next make sure to squash commits and do Squash and merge or Rebase and merge. Avoid creating merge commits when merging to master. |
Add notice for .NET Framework.