fix l/r in many-to-many.md for UsingEntity method calls #4609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typical signature overloads have params (joinEntityName, configureRight, configureLeft, configureJoinEntityType) in that order, but all the docs invert the left / right delegate order. This can give rise to join table with conflicting field names and FK navs, so is dangerous for learning "skip navigation". As Arthur wrote earlier "the code gets complicated quickly and its easy to make a mistake", yup! The Issue dotnet#4269 ' Major overhaul of the "relationships" documentation' needs correcting, so I offer this PR. HTH.
ajcvickers
approved these changes
Jan 9, 2024
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typical signature overloads have params (joinEntityName, configureRight, configureLeft, configureJoinEntityType) in that order, but all the docs invert the left / right delegate ordering.
This can give rise to join table with conflicting field names and FK navs, so is dangerous for learning "skip navigation".
As Arthur wrote earlier "the code gets complicated quickly and its easy to make a mistake", yup!
The Issue #4269 ' Major overhaul of the "relationships" documentation' needs correcting, so I offer this PR.
HTH.