Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Emit a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 1.0. #318

Closed
kfertitta opened this issue Apr 19, 2019 · 0 comments · Fixed by #323
Closed

Emit a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 1.0. #318

kfertitta opened this issue Apr 19, 2019 · 0 comments · Fixed by #323
Labels
enhancement

Comments

@kfertitta
Copy link

The following seems potentially worthy of a warning:

"version": "1.0.0-preview.{height}",
  "nugetPackageVersion": {
    "semVer": 1
  },
@kfertitta kfertitta changed the title Product a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 2.0. Emit a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 2.0. Apr 20, 2019
robmen added a commit to firegiant/Nerdbank.GitVersioning that referenced this issue Apr 22, 2019
@robmen
Emit a warning when SemVer 2.0 format version is used with explicit S…
00a9b3c 
…emVer 1.0

Should the user explicitly set `nugetPackageVersion.semVer` to `1` but
use a SemVer 2 prerelease in their `version` (such as: `1.0.0-preview.{height})
a warning will now be displayed telling the user they are probably not
getting what they expected.

Fixes dotnet#318
@robmen robmen mentioned this issue Apr 22, 2019
Merged
@kfertitta kfertitta changed the title Emit a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 2.0. Emit a warning when SemVer 2.0 format version is specified with explicitly selecting SemVer 1.0. Apr 22, 2019
AArnott added a commit that referenced this issue Dec 12, 2024
@AArnott
Merge pull request #318 from AArnott/githubActionsDevelopment
03ec9e0 
Add release GitHub workflow and improve others
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@AArnott @kfertitta