Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression - 3.4.190 no longer works with submodule #578

Closed
mhutch opened this issue Apr 7, 2021 · 1 comment · Fixed by #582
Closed

Regression - 3.4.190 no longer works with submodule #578

mhutch opened this issue Apr 7, 2021 · 1 comment · Fixed by #582
Assignees
Labels
Milestone

Comments

@mhutch
Copy link

mhutch commented Apr 7, 2021

I have a project that does not use GitVersioning itself, but submodules a project that uses GitVersioning. Using 3.4.190, it fails with an internal error "No git repo found here":

error MSB4018: The "Nerdbank.GitVersioning.Tasks.GetBuildVersion" task failed unexpectedly.
error MSB4018: System.ArgumentException: No git repo found here. (Parameter 'workingDirectory')
error MSB4018:    at Nerdbank.GitVersioning.Managed.ManagedGitContext..ctor(String workingDirectory, String dotGitPath, String committish)
error MSB4018:    at Nerdbank.GitVersioning.GitContext.Create(String path, String committish, Boolean writable)
error MSB4018:    at Nerdbank.GitVersioning.Tasks.GetBuildVersion.ExecuteInner()

I found that 3.3.37 works fine, so I used that and created a GitHub Action PR demonstrating that 3.3.37->3.4.190 upgrade breaks:

https://github.com/mhutch/MonoDevelop.Xml/actions/runs/724957601

@AArnott AArnott added this to the v3.4 milestone Apr 7, 2021
@AArnott AArnott added the bug label Apr 7, 2021
@AArnott
Copy link
Collaborator

AArnott commented Apr 7, 2021

Thanks for reporting. I'll investigate. In the meantime, you have two workarounds:

  1. Pin an older version of NB.GV to use
  2. Switch 3.4 back to the libgit2 engine as described in the release notes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants