Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve alternate parsing #596

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Improve alternate parsing #596

merged 3 commits into from
Apr 30, 2021

Conversation

qmfrederik
Copy link
Contributor

There are at least two bugs in alternate parsing:

  • On all platforms, the last value in the alternate files is ignored
  • On Windows, the colon in full paths (e.g. C:\Users\Me) is used as a separator

This PR attempts to fix both issues. Contributes towards #595

@AArnott AArnott changed the base branch from master to v3.4 April 29, 2021 17:23
@AArnott AArnott added this to the v3.4 milestone Apr 29, 2021
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple quick things to consider.

@AArnott
Copy link
Collaborator

AArnott commented Apr 29, 2021

@qmfrederik If you push to this PR again, keep in mind I rebased your commits to allow for targeting the fix to v3.4. You should do a fetch and git reset --hard origin/features/alternates before doing more work to avoid inadvertently merging master into v3.4.

@AArnott AArnott merged commit 2363be0 into dotnet:v3.4 Apr 30, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants