Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

HashCode not needed for ns2.1+ #637

Closed
WhiteBlackGoose opened this issue Oct 14, 2021 · 4 comments
Closed

HashCode not needed for ns2.1+ #637

WhiteBlackGoose opened this issue Oct 14, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@WhiteBlackGoose
Copy link
Contributor

After multitargeting, we can conditionally exclude HashCode from dep.
Assign me to this one
@WhiteBlackGoose WhiteBlackGoose added the enhancement New feature or request label Oct 14, 2021
@Perksey
Copy link
Member

Perksey commented Oct 14, 2021

I mean it’s also completely benign anyway as that package doesn’t install anything on NS21+

@WhiteBlackGoose
Copy link
Contributor Author

Uhm, does it not? May I ask how it works? 😅

@Perksey
Copy link
Member

Perksey commented Oct 14, 2021

Microsoft.Bcl.HashCode only has libs for .NET Standard 2.0. It multitargets to the newer frameworks, but excludes the DLL from the package so that when installed if we're somewhere where HashCode exists already, it doesn't install.

@WhiteBlackGoose
Copy link
Contributor Author

I see, thanks.

@nathan-alden-sr nathan-alden-sr mentioned this issue Oct 17, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Perksey @WhiteBlackGoose