Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove two NuGet package dependencies for certain TFMs #643

Closed
nathan-alden-sr opened this issue Oct 17, 2021 · 2 comments
Closed

Remove two NuGet package dependencies for certain TFMs #643

nathan-alden-sr opened this issue Oct 17, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request hacktoberfest
Milestone

Comments

@nathan-alden-sr
Copy link
Contributor

nathan-alden-sr commented Oct 17, 2021

Similar to #637, and as discussed on Discord here.

image

I noticed that the Silk.NET.Maths package (and perhaps others) include a couple of NuGet package dependencies for the net5.0 TFM. It seems like these packages are not necessary at all (and may not be for other TFMs, as well).

Many people/teams will make decisions about whether to use a package based explicitly on the package's dependencies, especially in the era of increasing package management supply chain attacks. If possible, it would be nice to see these two unneeded dependencies removed so Silk.NET.Maths is effectively standalone. That will give me piece-of-mind at a package security level. Although I am only using Silk.NET.Maths myself, it seems that if a change is made it should be made to all the other packages, as well.

@nathan-alden-sr nathan-alden-sr added the enhancement New feature or request label Oct 17, 2021
@HurricanKai HurricanKai added this to the 2.X milestone Oct 17, 2021
@HurricanKai
Copy link
Member

This should be a very simple change, just excluding the two packages above a certain .NET version (HashCode is available on .NET Standard 2.1, Net5, Net6, NetCore2+) (Half is available on Net5 and Net6)
Good Issue for Hacktoberfest, so I'll let it sit here for a while 🙂

@nathan-alden-sr
Copy link
Contributor Author

I'll pick this up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants