Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use ref readonly instead of in #1882

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Use ref readonly instead of in #1882

merged 8 commits into from
Mar 21, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jan 7, 2024

Manually defines the RequiresLocationAttribute given that we can't upgrade away from the .NET 7 SDK and thereby get C# 12.

@Perksey
Copy link
Member Author

Perksey commented Jan 7, 2024

Ready for review.

@Perksey Perksey marked this pull request as ready for review January 7, 2024 17:42
@Perksey Perksey requested review from Beyley, ThomasMiz, HurricanKai and a team as code owners January 7, 2024 17:42
@Perksey
Copy link
Member Author

Perksey commented Mar 19, 2024

Confirmed working by testing against vk.CreateInstance

unsafe
{
    var vk = Vk.GetApi();
    vk.CreateInstance(new InstanceCreateInfo(), null, null);
}
0>------- Started building project: Scratch
0>Program.cs(8,23): Warning CS9193 : Argument 1 should be a variable because it is passed to a 'ref readonly' parameter
Scratch -> /Users/dylan/Documents/RiderProjects/Scratch/Scratch/bin/Debug/net8.0/Scratch.dll
0>------- Finished building project: Scratch. Succeeded: True. Errors: 0. Warnings: 1

@Perksey
Copy link
Member Author

Perksey commented Mar 19, 2024

@Beyley Ready for review. I'm intending to update the non-Clang bindings at some point, did you want me to do that here or in a separate PR?

@Beyley
Copy link
Contributor

Beyley commented Mar 20, 2024

i think im too stupid to understand the reason for this, but the code itself looks good
after this is merged in i'll do a full update/regen of all the bindings including clang stuff

i'd do an approval but the github UI crashes trying to open the review interface

@Perksey
Copy link
Member Author

Perksey commented Mar 21, 2024

Force merging per Beyley's comment

@Perksey Perksey merged commit 7c38fa2 into main Mar 21, 2024
5 checks passed
@Perksey Perksey deleted the feature/ref-readonly branch March 21, 2024 03:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants