Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

License header fix #645

Merged
merged 2 commits into from
Oct 17, 2021
Merged

License header fix #645

merged 2 commits into from
Oct 17, 2021

Conversation

WhiteBlackGoose
Copy link
Contributor

Added solution file for Maths (three projects) to make smoother the experience for those who just want to edit those (it might be a good idea to add a solution file for each set of projects which are more or less independently edited).

And added missing license headers. Closes #634

@HurricanKai HurricanKai enabled auto-merge (squash) October 17, 2021 18:57
@@ -0,0 +1,37 @@

Microsoft Visual Studio Solution File, Format Version 12.00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding a sln file just for maths?

Copy link
Member

@Perksey Perksey Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it says in the description... I think I disagree with this, and if there is a need for this it should be:

  • configurable
  • baked into NUKE
  • gitignored

I don't want 14 sln files in the repo...

@Perksey Perksey disabled auto-merge October 17, 2021 19:13
@Perksey Perksey enabled auto-merge (squash) October 17, 2021 19:28
@Perksey Perksey merged commit 432cc4c into dotnet:main Oct 17, 2021
Perksey pushed a commit that referenced this pull request Nov 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License templates missing in some files
3 participants