Skip to content

Moved SmiXetterAccessMap to shared src folder #1310

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

Kaur-Parminder
Copy link
Contributor

Code merge for #1261 Issue for SmiXetterAccessMap class. Added the common code to .Common.cs class.

Code merge for dotnet#1261 Issue for SmiXetterAccessMap class. Added the common code to .Common.cs class.
@DavoudEshtehari DavoudEshtehari added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Oct 4, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Oct 4, 2021
@JRahnama
Copy link
Contributor

JRahnama commented Oct 8, 2021

@Kaur-Parminder can you address the conflict please?

@Kaur-Parminder
Copy link
Contributor Author

Kaur-Parminder commented Oct 8, 2021

@Kaur-Parminder can you address the conflict please?

@JRahnama Done.

@JRahnama
Copy link
Contributor

@Kaur-Parminder since the other PRs are merging and we have a lot this may happen more often. Please address the conflicts again. Thanks.

@cheenamalhotra cheenamalhotra merged commit 9fd88b1 into dotnet:main Oct 19, 2021
@Kaur-Parminder Kaur-Parminder deleted the Move-to-Shared-SmiXetterAccessMap branch January 12, 2022 03:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants