Skip to content

Move to shared - SmiMetaDataProperty #1320

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

Kaur-Parminder
Copy link
Contributor

This is part of #1261 Code Merge effort. Moved the file to common src folder. The Netfx and Netcore files were same.

This is part of dotnet#1261 Code Merge effort. Moved the file to common src folder. The Netfx and Netcore files were same.
@Kaur-Parminder Kaur-Parminder added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Oct 6, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 6, 2021
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some opportunities for code improvement in this file. Could you check the suggested changes by VS?

applied changes suggested by Visual Studio
@Kaur-Parminder
Copy link
Contributor Author

I see some opportunities for code improvement in this file. Could you check the suggested changes by VS?

I have added the VS suggestions.

Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing prefix: 's_' on line #36.
  • Missing prefix: '_' on lines #150 and #153.
  • Make field readonly on lines #28 and #89.

@Kaur-Parminder
Copy link
Contributor Author

@DavoudEshtehari Just Addressed those changes. Thanks.

@JRahnama JRahnama merged commit c0fd7d2 into dotnet:main Oct 15, 2021
@Kaur-Parminder Kaur-Parminder deleted the Move-To-Shared-SmiMetaDataProperty branch January 12, 2022 03:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants