-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixes ReadAsync() behavior to register Cancellation token action before streaming results #1781
Conversation
6457e7e
to
632fa98
Compare
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDataReader.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs
Outdated
Show resolved
Hide resolved
/azurepipilines run |
e607d46
to
49440fa
Compare
51f50d9
to
e79cfa6
Compare
Codecov ReportBase: 71.47% // Head: 71.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 71.47% 71.43% -0.05%
==========================================
Files 293 293
Lines 61381 61381
==========================================
- Hits 43872 43846 -26
- Misses 17509 17535 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@cheenamalhotra Please backport this to the 5.0.1 as well. Thanks! |
Fixes #1065 with test case added from comment.
cc @jnm2 @roji would appreciate some extra validations!