-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[.NET10] removal of generator
generated code in Additions/
#1058
base: main
Are you sure you want to change the base?
Conversation
Honestly that list isn't as bad as I feared. I guess for each manual code we have 3 options:
I suspect we'll have to do option (3) for most of these. |
I was pretty scared when JonP told me, but after I searched and gathered some info. It does not look bad.
This is what I intended - early discussion and those points were in my plan too. Maybe additionally
Bugs/problems will be in comments. 1st one coming in today. |
20241211 Problem android-libraries/source/androidx.activity/activity/Transforms/Metadata.xml Lines 402 to 408 in f237e90
For errors like:
Fix is to change parameter android-libraries/source/androidx.activity/activity/Transforms/Metadata.xml Lines 395 to 400 in f237e90
but in some cases this does not work:
Less optional alternative (Variant B) would be to change native Java android-libraries/source/androidx.activity/activity/Transforms/Metadata.xml Lines 455 to 478 in f237e90
|
…ttps://github.com/dotnet/android-libraries into mu-20241209-net10-removal-of-generator-workarounds
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…ttps://github.com/dotnet/android-libraries into mu-20241209-net10-removal-of-generator-workarounds
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Is this "done"? Is it green? |
It is green, but there are still few cases which will ned more love. |
Test errors for investigaton
|
…ttps://github.com/dotnet/android-libraries into mu-20241209-net10-removal-of-generator-workarounds
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Search git grep JNINativeWrapper
|
Context: due to the changes in
generator.exe
output old generator code that was used must be removed or regenerated.Initial investigation - files:
Highest priority for MAUI (needs deeper investigation, because of transitive dependencies):
Full list:
Details
Some bugs (generics arity) or missing features in
generator
were solved by usingremove-node
with previously copied generator code which was added toAdditions/
and manually modified.