Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Manual updates 20220710 new packages (androidx.enterprise, androidx.window:window-rxjava*...) #582

Merged
merged 44 commits into from
Aug 18, 2022
Merged

Manual updates 20220710 new packages (androidx.enterprise, androidx.window:window-rxjava*...) #582

merged 44 commits into from
Aug 18, 2022

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Jul 11, 2022 •
edited
Loading

Does this change any of the generated binding API's?

Most likely - new bindings + updates:

  • androidx.enterprise:enterprise-feedback - -> 1.0.0
  • androidx.window:window-rxjava2 - -> 1.0.0
  • androidx.window:window-rxjava3 - -> 1.0.0
  • com.google.assistant.appactions:suggestions - -> 1.0.0
  • com.google.assistant.appactions:widgets - -> 0.0.1
  • org.jetbrains.kotlinx:kotlinx-coroutines-rx3 - -> 1.6.2
  • com.google.flogger:flogger - -> 0.4
  • com.google.flogger:flogger-system-backend - -> 0.4
  • com.google.android.gms:play-services-basement - 17.0.0 -> 18.0.2
  • com.google.android.gms:play-services-tasks - -> 18.0.1

Describe your contribution

New bidnings added.

@moljac moljac changed the title Manual updates 20220710 new packages (androidx.enterprise, ...) Manual updates 20220710 new packages (androidx.enterprise, androidx.window:window-rxjava*...) Jul 11, 2022
@moljac moljac requested a review from jpobst July 15, 2022 09:53
@moljac
Copy link
Contributor Author

moljac commented Jul 16, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpobst
Copy link
Contributor

jpobst commented Jul 18, 2022 •
edited
Loading

This PR needs to only contain changes related to new bindings. Currently, this seems to include changes from many other open PRs. (144 files changed.)

I think we should also edit the PR description to specify why we are added each new package.

Are they customer requests? internal requests? new dependencies needed by updated versions of packages we already bind?

@moljac
Copy link
Contributor Author

moljac commented Jul 20, 2022 •
edited
Loading

Are they customer requests? internal requests? new dependencies needed by updated versions of packages we already bind?

Internal (updated in another PR:

Screen Shot 2022-07-20 at 09 10 47

External/community:

other are dependencies

This will not be good for me if I'll have to document and elaborate every single request I get and decision I make.

@moljac
Copy link
Contributor Author

moljac commented Jul 22, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moljac moljac requested a review from jonathanpeppers August 8, 2022 11:38
jpobst
jpobst reviewed Aug 8, 2022
View reviewed changes
published-namespaces.txt Outdated
@@ -324,6 +328,10 @@ Google.Android.Material.Tooltip
Google.Android.Material.Transformation
Google.Android.Material.Transition
Google.Android.Material.Transition.Platform
Google.Assistant.Appactions.Suggestions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppActions

published-namespaces.txt Outdated
Google.Assistant.Appactions.Suggestions
Google.Assistant.Appactions.Suggestions.Client
Google.Assistant.Appactions.Widgets
Google.Assistant.Appactions.Widgets.Pinappwidget
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PinAppWidget

templates/flogger/Project.cshtml Outdated
<TargetFrameworks>MonoAndroid12.0;net6.0-android</TargetFrameworks>
<IsBindingProject>true</IsBindingProject>
<RootNamespace>Annotations</RootNamespace>
<AssemblyName>Xamarin.Google.AutoValue.Annotations</AssemblyName>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!AutoValue

templates/flogger/Project.cshtml Outdated
<PropertyGroup>
<TargetFrameworks>MonoAndroid12.0;net6.0-android</TargetFrameworks>
<IsBindingProject>true</IsBindingProject>
<RootNamespace>Annotations</RootNamespace>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!Annotations

@moljac moljac requested a review from jpobst August 18, 2022 10:36
@moljac moljac merged commit d7be4a8 into main Aug 18, 2022
@moljac moljac deleted the mu-20220710-new-packages branch August 18, 2022 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jpobst jpobst jpobst approved these changes

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moljac @jpobst @jonathanpeppers