Adding resource dlls to MicroBuild signing. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
reviewed
Dec 1, 2021
src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj
Outdated
Show resolved
Hide resolved
pjcollins
approved these changes
Dec 1, 2021
thsparks
pushed a commit
that referenced
this pull request
Mar 21, 2022
BaRS is conducting an effort to migrate signing in Xamarin pipelines off the [external Groovy pipeline][0]. The goal is to use MicroBuild to handle all signing within the build rather than hand off files for another pipeline to sign. The [Android.SDK.Manager][1] pipeline has been chosen as the first pipeline to migrate. Project files in `Android.SDK.Manager` reference the [xamarin-android-tools repo][2] as a submodule and [sign the resource dlls][3] that the `Xamarin.Android.Tools.AndroidSdk` project creates. This change will move the signing of these resource dlls to the build of `Xamarin.Android.Tools.AndroidSdk`. The added `<GetFilesToSign/>` target enables the use of wildcards in MicroBuild. This change is not intended to impact the behavior of the `AndroidTools` build beyond the added signing. [0]: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=13878&_a=summary [1]: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=13502&_a=summary [2]: https://github.com/xamarin/android-sdk-installer/blob/684b7e1283706bef2e5c832a64ced0158abe5259/Xamarin.Installer.AndroidSDK.Manager/Xamarin.Installer.AndroidSDK.Manager.csproj#L154 [3]: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=5479174&view=logs&j=7082d35a-e46b-5a74-0b0f-e46ed113ca0e&t=9ebd6855-a6bc-5b9a-0813-711468e28365&l=91
thsparks
pushed a commit
that referenced
this pull request
Apr 18, 2022
BaRS is conducting an effort to migrate signing in Xamarin pipelines off the [external Groovy pipeline][0]. The goal is to use MicroBuild to handle all signing within the build rather than hand off files for another pipeline to sign. The [Android.SDK.Manager][1] pipeline has been chosen as the first pipeline to migrate. Project files in `Android.SDK.Manager` reference the [xamarin-android-tools repo][2] as a submodule and [sign the resource dlls][3] that the `Xamarin.Android.Tools.AndroidSdk` project creates. This change will move the signing of these resource dlls to the build of `Xamarin.Android.Tools.AndroidSdk`. The added `<GetFilesToSign/>` target enables the use of wildcards in MicroBuild. This change is not intended to impact the behavior of the `AndroidTools` build beyond the added signing. [0]: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=13878&_a=summary [1]: https://dev.azure.com/devdiv/DevDiv/_build?definitionId=13502&_a=summary [2]: https://github.com/xamarin/android-sdk-installer/blob/684b7e1283706bef2e5c832a64ced0158abe5259/Xamarin.Installer.AndroidSDK.Manager/Xamarin.Installer.AndroidSDK.Manager.csproj#L154 [3]: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=5479174&view=logs&j=7082d35a-e46b-5a74-0b0f-e46ed113ca0e&t=9ebd6855-a6bc-5b9a-0813-711468e28365&l=91
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaRS is conducting an effort to migrate signing in Xamarin pipelines off the external Groovy pipeline. The goal is to use MicroBuild to handle all signing within the build rather than hand off files for another pipeline to sign. The Android.SDK.Manager pipeline has been chosen as the first pipeline to migrate. Project files in Android.SDK.Manager reference the xamarin-android-tools repo as a submodule and sign the resource dlls that the Xamarin.Android.Tools.AndroidSdk project creates. This change will move the signing of these resource dlls to within the build of Xamarin.Android.Tools.AndroidSdk. The added "GetFilesToSign" target is to enable the use of wildcards in MicroBuild.
This change is not intended to impact the behavior of the AndroidTools build beyond the added signing.