Skip to content

[XABT] introduce $(EnableProfiler) property #10083

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

jonathanpeppers
Copy link
Member

Context: dotnet/macios#22685
Context: dotnet/macios#19370

To simplify inclusion of the Mono diagnostics component, the iOS/macOS/etc. workloads are introducing a new $(EnableProfiler) property.

To align with Android, we can make $(EnableProfiler) available and work the same way as the existing $(AndroidEnableProfiler) property.

I documented $(AndroidEnableProfiler) (which was missing!), and also added an entry about the new, $(EnableProfiler) property.

Context: dotnet/macios#22685
Context: dotnet/macios#19370

To simplify inclusion of the Mono diagnostics component, the
iOS/macOS/etc. workloads are introducing a new `$(EnableProfiler)`
property.

To align with Android, we can make `$(EnableProfiler)` available and
work the same way as the existing `$(AndroidEnableProfiler)` property.

I documented `$(AndroidEnableProfiler)` (which was missing!), and also
added an entry about the new, `$(EnableProfiler)` property.
@jonathanpeppers
Copy link
Member Author

I thought about updating this doc:

`$(AndroidEnableProfiler)` must be set to `true` as it includes the
Mono diagnostic component in the application. This component is the
`libmono-component-diagnostics_tracing.so` native library.
```sh
$ dotnet build -f net8.0-android -t:Run -c Release -p:AndroidEnableProfiler=true
```

But I think we should wait until this new $(EnableProfiler) property ships.

@jonathanpeppers jonathanpeppers removed the request for review from dellis1972 April 29, 2025 15:46
@jonpryor jonpryor merged commit 829b6c9 into main May 1, 2025
59 checks passed
@jonpryor jonpryor deleted the dev/peppers/EnableProfiler branch May 1, 2025 15:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants