Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ci] Skip classic tests on .NET release branches #7312

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

pjcollins
Copy link
Member

Related: #7286

Classic test jobs and VSIX installer provisioning will no longer run on
.NET release branches (branches starting with release/).

The MSBuild smoke test jobs have also been updated to run against the
net6.0 version of the Xamarin.Android.Build.Tests.dll and
MSBuildDeviceIntegration.dll test assemblies.

Related: dotnet#7286

Classic test jobs and VSIX installer provisioning will no longer run on
.NET release branches (branches starting with `release/`).

The MSBuild smoke test jobs have also been updated to run against the
`net6.0` version of the `Xamarin.Android.Build.Tests.dll` and
`MSBuildDeviceIntegration.dll` test assemblies.
@pjcollins pjcollins marked this pull request as ready for review August 26, 2022 18:15
@pjcollins pjcollins requested a review from jonpryor as a code owner August 26, 2022 18:15
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, to bring this idea to main.

I reran some test phases to see if this will be "greener".

@pjcollins
Copy link
Member Author

None of the remaining failures look related, going to merge this one.

@pjcollins pjcollins merged commit 78224d5 into dotnet:main Aug 29, 2022
@pjcollins pjcollins deleted the net-smoke branch August 29, 2022 21:11
jonathanpeppers pushed a commit that referenced this pull request Aug 29, 2022
Related: #7286

Classic test jobs and VSIX installer provisioning will no longer run on
.NET release branches (branches starting with `release/`).

The MSBuild smoke test jobs have also been updated to run against the
`net6.0` version of the `Xamarin.Android.Build.Tests.dll` and
`MSBuildDeviceIntegration.dll` test assemblies.
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 31, 2022
* main:
  [ci] Split up signing for files to be notarized (dotnet#7321)
  [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311)
  [ci] Skip classic tests on .NET release branches (dotnet#7312)
  [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320)
  Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308)
  Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 31, 2022
* mm-runtime:
  [ci] Split up signing for files to be notarized (dotnet#7321)
  [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311)
  [ci] Skip classic tests on .NET release branches (dotnet#7312)
  [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320)
  Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308)
  Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants